Add missing setImmediates method#588
Merged
Merged
Conversation
Contributor
Author
|
@kainino0x Please review |
Contributor
Author
|
Hold on a bit, it looks like it should match dawn.json, not WebGPU Javascript API. I'll update it shortly. Sorry for the noise. |
kainino0x
marked this pull request as draft
April 29, 2026 14:43
Collaborator
|
No worries, marking as draft |
beaufortfrancois
marked this pull request as ready for review
April 29, 2026 15:19
Contributor
Author
|
We should be good now! |
kainino0x
approved these changes
Apr 30, 2026
kainino0x
marked this pull request as draft
April 30, 2026 08:04
Collaborator
|
The WebGPU spec PR landed, doing the same for this one. |
Kangz
marked this pull request as ready for review
May 7, 2026 13:39
5 tasks
hmaarrfk
added a commit
to conda-forge-admin/webgpu-headers-feedstock
that referenced
this pull request
Jul 21, 2026
<details><summary>Claude's draft</summary>
wgpu-native v29.0.1.1 bumped its ffi/webgpu-headers submodule from
7d3186c3dd2c708703524027b46b8703534ab3cc to
673658bc2bd70ec39fc55ebe6bb0173cf6d0a603 ("Add missing setImmediates
method", webgpu-native/webgpu-headers#588, 2026-05-07), so track that
commit here. Note v27.0.4.1 and v29.0.0.0 both still pointed at
7d3186c3, which is why this only moves now.
The header diff is small: adds the WGPUWGSLLanguageFeatureName_
LinearIndexing enum value and the wgpu{Compute,Render}PassEncoder
SetImmediates proc pointer declarations.
Verified that webgpu.h at 673658bc is byte-identical to the copy
vendored in wgpu-py 0.32.0 (wgpu/resources/webgpu.h), which is the
release that targets wgpu-native 29.0.1.1 -- so this is exactly the
right commit for that stack.
Built locally with .ci_support/linux_64_.yaml: produces
webgpu-headers-0.0.0.2026.5.7.673658b-h707e725_0.conda shipping
include/webgpu.h with the expected contents. The new version string
sorts above the current 0.0.0.2026.3.19.7d3186c per conda's
VersionOrder, so the build number stays at 0.
Resume this Claude session:
```
cd /Users/mark/git/feedstocks
claude --resume 373eb0f8-42bc-4c6c-aa5f-2136f7a0cc4f
```
</details>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds missing the
setImmediatesmethod as described in gpuweb/gpuweb#5423